Improved Visual Cohesion on About Us Page #113
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening a pull request @admwln. We'll will review it as soon as possible 🙌❤️
There was a problem hiding this comment.
Hey @admwln. Could you please provide a screenshot of the result.
|
Hey @Virtual4087 Sure thing! Desktop: Mobile: |
|
I had another go of it, with a more subtle background, and some minor style changes: Please note that I have added a background color to body for smaller screens. The following image illustrates what happens without said change. The problem seems to arise because of how the background photograph is implemented, however, I could not find a satisfying solution. |
|
Oh I see, it seems that pr #121, which is already merged to main, fixes issue #107 (that the present pr tries to solve). The two prs are not compatible. It's one or the other, as far as I can tell. I have no problem with you choosing the other solution over mine. It was a fun exercise! Looking at the newly merged changes, it seems that pr #121 fixes the problem that's depicted in my last screenshot, so it might be preferable regardless. |
There was a problem hiding this comment.
@admwln True but I don't want to not merge your changes after you've already done so much. So maybe you could create another fork and just change the text format like color and stuff to make it more clean? The current "About Us" section's text content is not very appealing. If you can you can make it more minimalistic.
|
Thank you, @Virtual4087. See pr #122. |
|
@admwln Done I'll be closing this pr. Thanks for the help. |
Fixes #107 : Change About Us page design
I have enhanced the visual cohesion between the background of the About Me page and the foreground content by:
This change helps unify the background and foreground elements, creating a smoother and more cohesive design. The effect is subtle but noticeable, and it improves the overall aesthetics of the page without being distracting.
Testing: